Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7092 - Estimated Runtime Scaling

Attached to Project: Rockbox
Opened by Simon Menzel (Rincewind) - Monday, 30 April 2007, 15:15 GMT+1
Last edited by Jonathan Gordon (jdgordon) - Monday, 30 April 2007, 15:20 GMT+1
Task Type Patches
Category Battery/Charging
Status New
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This patch adds a new Setting "System -> Battery -> Estimated Maximum Runtime". Users can set the maximum runtime they get on average.
This value is then used to scale the estimated runtime display in the info screen and the WPS tag.

This is useful when when the battery is very old and on targets where the runtime display isn't calibrated very well.
A similar effect could be achieved with changing the battery capacity value, but this may have unwanted side effects and is not very
userfriendly.

Should work on all targets (someone should check my code for the archos players, though).
   runtime.patch (4.8 KiB)
This task depends upon

Comment by Jonathan Gordon (jdgordon) - Monday, 30 April 2007, 15:22 GMT+1
patch looks ok (havnt actually tested it though), except your adding the new var in the settings struct in the middle... it needs to go at the end unless we want the plugin version to be bumped
Comment by Simon Menzel (Rincewind) - Monday, 30 April 2007, 15:48 GMT+1
fixed.
   runtime.patch (4.4 KiB)
Comment by Sal (Errant33) - Friday, 03 August 2007, 20:25 GMT+1
both patches failed in a few spots the one in comments failed in 3 hunks
Comment by Dave Germiquet (enterusername) - Monday, 27 August 2007, 02:33 GMT+1
Does this work? I patched it and then edited the rejects I don't see the option under System/Battery?
Comment by Simon Menzel (Rincewind) - Monday, 27 August 2007, 12:15 GMT+1
there have been quite a few changes to the power management code. I'm afraid this patch doesn't work anymore.
I fix it in the next few days.
Comment by Jack Suter (chrisjs169) - Monday, 27 August 2007, 16:12 GMT+1
Works fine on the Sansa. I had to change the code a little because they battery menu was removed. I don't have a copy of the patch (directly edited parts of the source to make it work) though I might be able to get one working. If you re-enable the battery menu (IIRC, it's just an if statement) you should have it working again.
Comment by Chris (decayed.cell) - Wednesday, 05 September 2007, 11:50 GMT+1
Perhaps use svn diff feature to generate a patch?

Loading...